ci: keep CodeQL init/analyze on one SHA and unstick msgpack bumps - #29
ci: keep CodeQL init/analyze on one SHA and unstick msgpack bumps#29sumitake wants to merge 1 commit into
Conversation
Dependabot treated github/codeql-action/init and /analyze as separate dependencies, so each PR loaded config 4.37.9 against analyzer 4.37.8. Group GitHub Actions updates, bump both pins together, and make the msgpack audit compare requirements.txt to pyproject.toml instead of a hardcoded version.
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0161c29512
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pinned = re.search(r'"((?:msgpack==)[0-9][0-9.]*)"', pyproject) | ||
| if pinned is None or requirement != pinned.group(1): | ||
| errors.append("requirements.txt must pin the same msgpack version as pyproject.toml") |
There was a problem hiding this comment.
When the next Dependabot pip update changes both manifests, this check will pass even though Dependabot does not update the exact version literals in THIRD_PARTY_NOTICES.md:23 and docs/architecture-and-operations.md:233. Those files will consequently continue claiming the old runtime version. Either include those literals in the synchronization check or avoid documenting a duplicated exact version.
Useful? React with 👍 / 👎.
1 participant
Dependabot opened separate PRs for
codeql-action/initandcodeql-action/analyze. CodeQL then fails with:Loaded a configuration file for version '4.37.9', but running version '4.37.8'That happens on every CodeQL bump unless both
uses:lines move together.This PR:
cdf488f5)validate_repository.pyrequirerequirements.txtto match the pyproject msgpack pin (unblocks msgpack 1.2.1 → 1.2.2)Supersedes #26, #27, and #28.