Repository navigation
🐛(s3) use a valid default region for custom endpoints - #122
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Tip 🎯 Customize your risk assessments
✅ Automatic approvals, with your rules
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Attachment uploads fail with a 500 when
S3_REGIONis not set:The S3 hook falls back to
region: '-'when no region is configured. Since the@aws-sdk/client-s3bump in #100 (3.698.0 → 3.1132.0), the SDK requires the region tobe a valid hostname component and rejects
'-'.Current behavior: uploads fail on staging. Prod still works only because it runs a
build from before #100. It will break the same way on its next deploy.
New behavior: the fallback region is
us-east-1. With a custom endpoint (Scaleway),the region is only used for SigV4 signing, so any valid value works.
Pull-Request Checklist
mainbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000— N/A