gtk4: migrate GTK3 container and layout APIs to GTK4 equivalents - #1093
Open
Dev10-sys wants to merge 2 commits into
Open
gtk4: migrate GTK3 container and layout APIs to GTK4 equivalents#1093Dev10-sys wants to merge 2 commits into
Dev10-sys wants to merge 2 commits into
Conversation
- Replace Gtk.VBox and Gtk.HBox with Gtk.Box - Replace Gtk.Alignment with halign/valign and margins - Replace pack_start/pack_end with append/prepend - Replace set_border_width with margin properties - Replace Gtk.EventBox with Gtk.Box - Replace Gtk.Toolbar and Gtk.ToolItem with Gtk.Box - Replace Gdk.Screen with Gdk.Display monitor geometry - Remove deprecated show_all() calls No logic or functionality changed. Only deprecated GTK3 container APIs migrated.
chimosky
reviewed
Mar 24, 2026
…grate Gtk.Toolbar to Gtk.Box
Contributor
Author
|
Thanks for the review. I have updated the alignment usage in aboutme/view.py to avoid the extra container and applied alignment directly to the child. I have also updated the toolbar container replacement to use the appropriate Gtk.Box and append() instead of insert(). Please let me know if this looks correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No logic or functionality changed. Only deprecated GTK3 container APIs migrated.