Skip to content

fix:RAG retrieval path and similarity scoring (#130) - #165

Open
RaviSoni804426 wants to merge 1 commit into
sugarlabs:mainfrom
RaviSoni804426:fix/rag-retrieval-130
Open

fix:RAG retrieval path and similarity scoring (#130)#165
RaviSoni804426 wants to merge 1 commit into
sugarlabs:mainfrom
RaviSoni804426:fix/rag-retrieval-130

Conversation

@RaviSoni804426

Copy link
Copy Markdown

Fixes #130

  • Fixes vector store retrieval in RAGAgent by using the raw FAISS instance instead of VectorStoreRetriever.
  • Converts FAISS L2 distance to normalized similarity score 1 / (1 + distance).
  • Removes redundant double-assignment in main.py.
  • Adds comprehensive unit tests for RAG retrieval in tests/test_rag_retrieval.py (8/8 passing).

Copilot AI lite review requested due to automatic review settings September 4, 2026 06:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@RaviSoni804426 RaviSoni804426 changed the title fix: fix RAG retrieval path and similarity scoring (#130) fix:RAG retrieval path and similarity scoring (#130) Sep 4, 2026
@vyagh

vyagh commented Sep 4, 2026

Copy link
Copy Markdown
Member

@Noaman-Akhtar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The RAG retrieval path in run() is non-functional due to two compounding defects

3 participants