add a /reflect/chat endpoint for journal reflection - #163
Open
vyagh wants to merge 6 commits into
Open
Conversation
Member
Author
|
@Noaman-Akhtar please take a look at your convenience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief
Server half of the Journal's reflection feature. The client side is sugarlabs/sugar#1117 onward; sugarlabs/sugar#1123 is what calls this endpoint.
What this adds
How it's put together
Two things I'd like settled in review
1. The dependency
The engine installs from its pinned v0.1.0 release via requirements.txt. Should it eventually live on PyPI, and under whose account?
2. Images
Requests may carry image context in the engine's encoding, size-capped here; this service never reads inside it.
Images reach the model only when the deployment sets AI_SUPPORTS_IMAGES=1 and the provider can carry image parts; otherwise they drop and the text flows on.
Tests