Fix race condition in quota tracking using thread lock - #138
Open
lakshayg2005 wants to merge 1 commit into
Open
Conversation
Member
|
Not reviewed, could you improve on your commit message? |
lakshayg2005
force-pushed
the
fix/quota-race-condition
branch
from
May 20, 2026 21:14
e5759ac to
0d197f4
Compare
Author
|
@chimosky I’ve updated the commit message. Please review when convenient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a race condition in the
user_quotasin-memory tracking system used for API rate limiting.Previously, the quota dictionary was updated without any synchronization mechanism, which could lead to inconsistent behavior under concurrent requests.
Problem
The original implementation used a shared global dictionary:
This structure was modified directly in multiple requests:
Solution
Introduced thread-safety using
threading.Lockto ensure atomic access to the quota dictionary.Key changes:
Impact
Testing
/ask-llmendpoint with multiple sequential requestsNotes
This is an in-memory solution suitable for single-instance deployments. For distributed systems, a centralized store like Redis would be more appropriate.