fix: replace max_length with max_new_tokens and add basic chat context budgeting - #131
Open
Shivang731 wants to merge 1 commit into
Open
fix: replace max_length with max_new_tokens and add basic chat context budgeting#131Shivang731 wants to merge 1 commit into
Shivang731 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #120
Summary
This PR fixes two concrete problems in the current Hugging Face generation path:
What changed
app/context.py
Adds a small context-management helper for the current backend path:
app/ai.py
app/config.py
Adds configurable settings for:
app/routes/api.py
Scope
This PR adds basic application-level safeguards for the current inference path.
It does not yet implement: