Skip to content

Adopt NDK marketplace order flows#2

Closed
pats2sats wants to merge 3 commits into
mainfrom
feat/ndk-marketplace
Closed

Adopt NDK marketplace order flows#2
pats2sats wants to merge 3 commits into
mainfrom
feat/ndk-marketplace

Conversation

@pats2sats

@pats2sats pats2sats commented May 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Removes the Hostr-side marketplace transition adapter; order writes now record transitions through ndk.marketplace.orderTransitions directly.
  • Renames the remaining Hostr-specific group service to OrderGroupVerification, keeping only proof/on-chain verification in Hostr. Generic grouping/querying now delegates to NDK marketplace orders.
  • Moves the public Hostr runtime surface away from old Hostr wrappers: orderWorkflows and orderGroupVerification replace the old runtime getters, and the CLI/MCP action namespace is now hostr.orders.* / hostr_orders_*.
  • Keeps Hostr responsible for the heavy app-specific pieces: H3/polygon/location enrichment, chain/Boltz/swap orchestration, escrow verification, participant proofs, and UI/workflow composition.
  • Regenerates MCP action docs/types and updates AI server guidance/tests to the new order tool names.

Responsibility Split

  • NDK owns marketplace protocol shapes, generic inbox parsing, order grouping, order transition construction/querying, and domain-level invalid-stage prevention.
  • Hostr owns payment and escrow orchestration, Hostr participant authorization/proofs, listing location enrichment, and validation that depends on chain state or app policy.
  • The inbox domain remains generic and does not know about marketplace kinds.

Validation

  • dart analyze in hostr_sdk
  • dart test in hostr_sdk (830 passing)
  • dart analyze in hostr_cli
  • dart test in hostr_cli (19 passing, 3 skipped)
  • npm run test:unit in ai/mcp-server (38 passing)
  • flutter analyze in app
  • flutter test in app (48 passing)
  • dart analyze in escrow
  • dart test in escrow (6 passing)

Copilot AI review requested due to automatic review settings May 20, 2026 01:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Hostr’s Dart/Flutter workspaces to use the sudonym-btc/ndk fork’s feat/ndk-marketplace branch and refreshes lockfiles to the specific NDK commit referenced in the PR description.

Changes:

  • Point ndk dependency overrides (app, SDK, CLI, escrow, widgetbook workspace) to ref: feat/ndk-marketplace.
  • Refresh pubspec.lock files so ndk resolves to commit 7f87e28284a5d8ed5371e2d5a12f2c9fa7dc78bc.

Reviewed changes

Copilot reviewed 5 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
hostr_sdk/pubspec.yaml Switch NDK git override ref to feat/ndk-marketplace.
hostr_sdk/pubspec.lock Pin NDK resolved commit to 7f87e282….
hostr_cli/pubspec.yaml Switch NDK git override ref to feat/ndk-marketplace.
hostr_cli/pubspec.lock Pin NDK resolved commit to 7f87e282….
escrow/pubspec.yaml Switch NDK git override ref to feat/ndk-marketplace.
escrow/pubspec.lock Pin NDK resolved commit to 7f87e282….
app/widgetbook_workspace/pubspec.yaml Switch NDK git override ref to feat/ndk-marketplace.
app/widgetbook_workspace/pubspec.lock Pin NDK resolved commit to 7f87e282….
app/pubspec.yaml Switch NDK git override ref to feat/ndk-marketplace.
app/pubspec.lock Pin NDK resolved commit to 7f87e282….

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread hostr_sdk/pubspec.yaml
git:
url: https://github.com/sudonym-btc/ndk.git
ref: codex/hostr-ndk-fixes-upstream-master
ref: feat/ndk-marketplace
Comment thread hostr_cli/pubspec.yaml
git:
url: https://github.com/sudonym-btc/ndk.git
ref: codex/hostr-ndk-fixes-upstream-master
ref: feat/ndk-marketplace
Comment thread escrow/pubspec.yaml
git:
url: https://github.com/sudonym-btc/ndk.git
ref: codex/hostr-ndk-fixes-upstream-master
ref: feat/ndk-marketplace
git:
url: https://github.com/sudonym-btc/ndk.git
ref: codex/hostr-ndk-fixes-upstream-master
ref: feat/ndk-marketplace
Comment thread app/pubspec.yaml
git:
url: https://github.com/sudonym-btc/ndk.git
ref: codex/hostr-ndk-fixes-upstream-master
ref: feat/ndk-marketplace
@pats2sats
pats2sats force-pushed the feat/ndk-marketplace branch from 1daa396 to d374f61 Compare May 20, 2026 01:18
@pats2sats
pats2sats force-pushed the feat/ndk-marketplace branch from d374f61 to 0b84081 Compare May 20, 2026 01:36
@pats2sats pats2sats changed the title Use NDK marketplace branch Adopt NDK marketplace order flows May 20, 2026
@pats2sats pats2sats closed this May 20, 2026
@pats2sats
pats2sats deleted the feat/ndk-marketplace branch May 20, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants