fix(renderer): skip hidden-messages notice in message navigation#461
Open
phanen wants to merge 1 commit into
Open
fix(renderer): skip hidden-messages notice in message navigation#461phanen wants to merge 1 commit into
phanen wants to merge 1 commit into
Conversation
Problem: when max_messages truncates older messages, the synthetic hidden-messages notice (appended to state.messages via on_message_updated) is matched by get_prev_rendered_message, so [[ yanks the cursor to the buffer top. Solution: skip entries where is_renderer_synthetic_message is true in both get_prev_rendered_message and get_next_rendered_message.
phanen
force-pushed
the
fix/jump-previous
branch
from
efccdb8 to
34fce21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: when max_messages truncates older messages, the synthetic
hidden-messages notice (appended to state.messages via
on_message_updated) is matched by get_prev_rendered_message, so [[
yanks the cursor to the buffer top.
Solution: skip entries where is_renderer_synthetic_message is true in
both get_prev_rendered_message and get_next_rendered_message.