fix(navigation): preserve jumplist before output buffer jumps#456
Merged
Conversation
phanen
commented
Jul 9, 2026
Contributor
Problem: programmatic cursor moves via nvim_win_set_cursor in the output window (gg, ]], [[, ]u, [u, <CR>, ...) do not update the previous-position mark, so users cannot return to the prior output location with `` or <C-o> after a jump. Solution: introduce mark_jump_position() which records the current cursor as the ' mark inside the source window via `noau normal! m'`, and call it before every nvim_win_set_cursor in navigation.lua and before the gg keymap in output_window.lua.
Owner
|
Thanks for the PR. This is another great QOL improvement |
Contributor
Author
|
test seems flaky on master https://github.com/sudo-tee/opencode.nvim/actions/runs/29008327834/job/86085345936 |
Owner
|
Yes, it's always the same MacOs test that times out.. I will investigate |
Owner
|
I pushed a fix, to use a fake timer instead of relying on vim.wait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.