[FEATURE] Allow SiteSets for wizard#15
Merged
Merged
Conversation
The CreateProcess used `Environment::getProjectPath()` for writing and
detecting the site config path. This works fine in composer mode
instances but lacks path configuration in classic installations.
Use the `Environment::getConfigPath()` instead to always detect the
correct path.
As a necessary change, installed the site-based test trait extension
from sbuerk to ensure correct behaviour during functional test setup.
Used command:
```
Build/Scripts/runTests.sh -t 13 -p 8.2 -s composer -- require --dev \
sbuerk/typo3-site-based-test-trait:"^2.0 || ^3.0"
```
calien666
force-pushed
the
smaller-fixes
branch
2 times, most recently
from
d65d246 to
5f5f606
Compare
With TYPO3 13, SiteSets were introduced in favour of shipping presets for usage in site configuration. In favour of this new functionality, the wizard has to respect the site sets and should ship them within the creation process. Added the TCA for the table creator matching the TCA functionality from SiteConfiguration and placed the default handling of the SiteSets right before the `BeforeSiteConfigWriteEvent` to allow manual adjustments by an EventListener in case of this is needed. Cleaned up the ext_tables.sql and removed the table for creator completely, as TYPO3 is managing the required fields by TCA definition.
foppelfb
approved these changes
Jun 3, 2026
foppelfb
left a comment
foppelfb
left a comment
Member
There was a problem hiding this comment.
No further comments.
thank @calien666
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With TYPO3 13, SiteSets were introduced in favour of shipping presets
for usage in site configuration.
In favour of this new functionality, the wizard has to respect the site
sets and should ship them within the creation process.
Added the TCA for the table creator matching the TCA functionality from
SiteConfiguration and placed the default handling of the SiteSets
right before the
BeforeSiteConfigWriteEventto allow manualadjustments by an EventListener in case of this is needed.