Skip to content

feat(error-trace): add execute proof trace field#235

Merged
fakedev9999 merged 1 commit into
mainfrom
fakedev9999/execute-proof-error-trace
Jun 25, 2026
Merged

feat(error-trace): add execute proof trace field#235
fakedev9999 merged 1 commit into
mainfrom
fakedev9999/execute-proof-error-trace

Conversation

@fakedev9999

Copy link
Copy Markdown
Member

Summary

  • Adds optional ExecuteProofRequestBody.error_trace = 11 to the network wire type.
  • Keeps it wire-aligned with network-services j/vapp, which already receives, sanitizes, and stores this field (requests.error_trace).
  • Enables the follow-up sp1-cluster-private MainnetExecutor wiring to send structured traces on execute_proof.

Scope

  • Wire contract only: proto field + regenerated Rust types.
  • No producer wiring in this PR (sp1-cluster-private unchanged).
  • No network-services / infra / release changes.
  • Additive and backward-compatible: optional field, next free tag (11); old producers omitting it decode as None, old consumers ignore it.
  • Does not capture guest panic payload/location (separate SP1 stderr-capture work).

Validation

  • cargo build -p spn-network-types --release (regenerates src/types.rs via build.rs)
  • cargo test -p spn-network-types error_trace --lib → 52 passed
  • cargo fmt -p spn-network-types -- --check → clean
  • git diff --check → clean
  • Diff limited to proto/types.proto (+ field) and crates/types/network/src/types.rs (regenerated): #[prost(bytes = "vec", optional, tag = "11")] error_trace.

@fakedev9999 fakedev9999 force-pushed the fakedev9999/execute-proof-error-trace branch from eb9b37a to be02f2b Compare June 24, 2026 03:14
Add optional bytes error_trace = 11 to ExecuteProofRequestBody and regenerate
the Rust types. Wire-aligned with network-services j/vapp, which already
receives/sanitizes/stores the field. Wire contract only — no producer wiring.
@fakedev9999 fakedev9999 force-pushed the fakedev9999/execute-proof-error-trace branch from be02f2b to ff278b6 Compare June 24, 2026 03:30
@fakedev9999 fakedev9999 merged commit 9f42e07 into main Jun 25, 2026
4 checks passed
@fakedev9999 fakedev9999 deleted the fakedev9999/execute-proof-error-trace branch June 25, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants