feat(proto): remove ComponentInfo.instance_id from ReportProverInfo contract#234
Merged
Merged
Conversation
This was referenced Jun 24, 2026
fakedev9999
force-pushed
the
chore/remove-componentinfo-instance-id
branch
from
77e100b to
742578c
Compare
Farhad-Shabani
approved these changes
Jun 25, 2026
…ontract Worker ids are ECS task (launch) identities, not stable build identities, so the public build-reporting contract is keyed by (component, version, git_sha, image_tag). The never-shipped instance_id is removed outright and the remaining build fields are renumbered to a contiguous 1..4 (version=2, git_sha=3, image_tag=4) — no reserved marker — since no producer traffic has shipped. No RPC / signing / domain / other proto changes; regenerated spn-network-types.
fakedev9999
force-pushed
the
chore/remove-componentinfo-instance-id
branch
from
742578c to
e07e786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
ComponentInfo.instance_idfrom theReportProverInfopublic wire contract. The field is removed outright (noreservedmarker) since no producer traffic has shipped.Worker IDs are ECS task IDs in the producer path, so they are launch identities rather than stable build identities. The build-reporting contract should describe active component builds, keyed by
(component, version, git_sha, image_tag), not per-worker instances.Notes
instance_idwas removed outright (noreservedmarker) and the remaining build fields were renumbered contiguously (version=2,git_sha=3,image_tag=4), since no producer traffic has shipped.