Conversation
The stock keycloakify useIsPasswordRevealed hook uses a MutationObserver that reverts any external change to a password input's type attribute back to whatever the reveal-toggle state says it should be. Some mobile autofill flows briefly flip type from password to text to write the value before flipping back; the observer fought that. Replace it with a local hook that only sets type in response to the user's own toggle click. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should address issues with password manager autofill behavior on mobile only, where the password manager is unable fill in credentials due to an observer preventing an extension from toggling the field type. keyword should.