Repository navigation
feat(web): launch terminals and subshells from machine groups - #450
Merged
Merged
Conversation
openLaunch takes no argument on purpose: handing it to a Button's onClick made the click event the node pick, so the empty-state CTA opened a launch form seeded with a SyntheticEvent. openLaunchOnNode keeps the per-machine entry point, and a required string makes the handler-shaped wiring a compile error. The directory picker's capture-phase Escape claim now covers only events addressed inside the picker, so a popup tabbed to while the panel sat open still gets its dismissal. Pins both regressions.
The review fix shipped the event-passing trigger in node-launch-menu's setup but no test passed the flag, so the MAJOR's pin never ran. Now it does: the CTA opens the launch dialog on the prior launch's node and directory, and no event ever names a machine to /recent. quick-add's own trigger drops its now-unneeded wrapper for the direct pass that just bit the CTA, and openSshLaunch gains a note that its optional draft is call-by-wrapper only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine group headings in both sidebar lists now have a + menu. New terminal starts the terminal plugin on that node using its latest working directory, falling back to its home directory. New subshell opens the launch dialog with that node selected. Both paths retain the existing launch restrictions and workspace filing behavior, and the controls match the sidebar's icon sizing and alignment.
Directory, Recent, and Favorite selections now close the directory picker without reopening it when focus returns to the input. Reopening the launch dialog also preserves its directory default when paths are cached, including React Strict Mode effect replay.
Validation: