Repository navigation
feat: share presets and import versioned preset files - #393
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent and SSH presets can now be shared with individual users or Everyone, with View and Edit access. Owners retain control of sharing and deletion, and both preset tables show the owner. Using a shared preset still requires the caller's node and SSH permissions; revoked preset access prevents future starts without stopping an existing subshell.
Presets can also be exported as
<name>.presetJSON files and imported as private copies through the native file picker. Version 1 validates the file before saving, allows node remapping, and excludes ownership and sharing grants. Duplicate names appear beside the Name field. Cloning preserves stored settings and exact arguments.Shared fact labels now use stronger visual hierarchy. Sharing controls stay disabled during saves, and import drafts survive Escape and outside clicks.
Validation:
Includes database migration 0057 and server/docs changesets. Exported agent presets can contain environment secrets; the sharing and import UI explains this disclosure.
The Nodes list's Share action now opens sharing directly instead of navigating to config. Failed node-sharing reads block edits until a successful retry; focused and browser regressions cover the flow. Incremental review returned zero major or minor findings, and the full local verification passed again.