Repository navigation
fix: unify dashboard facts and conditional form behavior - #391
Merged
Merged
Conversation
Fact copying, validation tone, and the Save-unchanged comparison now go through shared logic instead of per-site guesses, the restore overrides move to a named section below their mode group (they apply to both), and the supervision dialog drops the panes line by its text rather than its index. The destination-confirmation e2e spec and docs follow the fingerprint out of the disclosure it shipped behind; a whitespace-only field reads the same tone on both backup cards; the ChoiceFields-in-group decision is recorded where the a11y rules live. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The first pass wrote that sharing lost a separate unsaved-changes sentence; it never had one, and the accurate rule is that Save's disabled state carries the pending-change fact. The coverage note now names the tests the review round added (tone split, supervision wording, restore override placement, draft comparison) and the e2e retargeting. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The unchanged-draft rule shipped tested on four surfaces and untested
on five. The one that writes to the server needed it most:
network-settings-form now proves a reverted field is dropped from the
PATCH body (not just from the button), and its boolean and secret
branches are exercised too. The profile, device-name, instance-name,
and provider surfaces get mount-disabled, type-enabled, revert-deadened
tests, so the rule is pinned at all nine.
Also the review's NITs: the two reverted-draft tooltips move to the
"No X changes to save." wording they now actually cover, the two no-op
`{ … }` JSX wrappers left by the removed conditionals are unwrapped in
ssh-wizard, and the supervision notice's lead sentence gets its period.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The prompt editor's edit mode now has its own pin (create mode can never see the unchanged-draft path, and the test file rendered create only), and the backup card's gold side — blur the empty box, get text-warning — is asserted next to the red side the retarget left alone. The changeset gains "@internal/docs": minor, which is what drives the docs.yml deploy; without it the rewritten destination-confirmation guide and its screenshot would sit unpublished until some later docs change happened to carry a bump. The per-app AGENTS.md line that still described the removed "Verification details" disclosure now says the confirmation shows the fingerprint outright, and two prose nits (colour spelling, an over-length wrapped rule line) went with it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The gate was pinned; the wire was not. A real change now has to ride the PUT once, carrying the full replacement draft, before the dialog closes and reports done — the submit half of the edit loop that the create-mode tests could never reach. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-only labels and values blended together across the dashboard, conditional fields appeared after entire radio groups, and several editors enabled Save without an actual change. This makes those patterns consistent across the dashboard and shared node cards.
docs/ux-review-2026-10-17.md, update the design guide, and add release notes for the server, node, and docs site.Validation: workspace build, type checks, lint, prose/design checks, and all 54 test tasks passed. The destination-confirmation e2e spec and its docs page were retargeted at the always-visible fingerprint (the disclosure the first pass removed), and the docs screenshot was regenerated from the new dialog against a sandbox instance. Browser checks covered 19 distinct dashboard surfaces at 320px and 1600px with no document-level horizontal overflow in the sandbox data, plus SSH conditional forms and Restore source selection.
Browser coverage does not include native desktop/mobile surfaces or end-to-end external identity, remote key, server replacement, and populated backup recovery flows. These limits are recorded in the audit.