[JavaScript] Remove possibly stray branch failure#4563
Draft
deathaxe wants to merge 1 commit into
Draft
Conversation
This commit removes `ts-function-type-arguments` branch point failure from `ts-type-expression-end` as this context is also used in non-function-call expressions. Implementing failure outside of related branch points may have unpredictable side effects. Instead add a negative lookahead to prevent `||` or `&&` being consumed as sequence of type operators. Possible branch point failure is to be handled by "calling" context after popping `ts-type-expression-end`. Added tests should illustrate it not affecting syntax highlighting behavior of generic function calls.
deathaxe
marked this pull request as draft
June 11, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes
ts-function-type-argumentsbranch point failure fromts-type-expression-endas this context is also used in non-function-call expressions. Implementing failure outside of related branch points may have unpredictable side effects.Instead add a negative lookahead to prevent
||or&&being consumed as sequence of type operators. Possible branch point failure is to be handled by "calling" context after poppingts-type-expression-end.Added tests should illustrate it not affecting syntax highlighting behavior of generic function calls.