fix(apply): re-render templates when source hash unchanged#24
Merged
Conversation
added 2 commits
July 23, 2026 06:56
The apply path marked files as unchanged when the raw source hash matched the DB record, even if variables had changed. Now it re-renders template/encrypted files and compares against the target, marking as modified when the rendered output differs.
Remove Applier.checkChange and have Apply call the shared computeChange from diff.go directly. This eliminates ~150 lines of duplicated change-detection logic that was prone to diverging (the template re-rendering fix had to be applied in both places). The only semantic difference was StatusStateOnly vs StatusUnchanged for the "no state entry, content matches" case. computeChange now returns StatusStateOnly there, and ComputeChanges filters it out alongside StatusUnchanged so status/diff behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apply path marked files as unchanged when the raw source hash
matched the DB record, even if variables had changed. Now it
re-renders template/encrypted files and compares against the target,
marking as modified when the rendered output differs.