fix(source): propagate perm-r, owner-r, group-r from parent directories#21
Merged
Conversation
getParentAttrs only collected non-recursive attributes (perm, owner, group) from parent directory names but ignored the recursive variants (perm-r, owner-r, group-r). This meant a directory named bin#perm-r:755 parsed correctly but never passed PermR to its children via Merge, so files inside got Perm=0 and permission-aware diffing never triggered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getParentAttrsonly collected non-recursive attributes (perm,owner,group) from parent directory names but ignored the recursive variants (perm-r,owner-r,group-r). A directory namedbin#perm-r:755parsed correctly but never passedPermRto children, so files inside gotPerm=0and permission-aware diffing (PR fix(target): detect and fix permission mismatches on status and apply #20) never triggered.Test Plan
make testpasses — addedTestScannerPermRInheritancemake lint— 0 issuesmate managedagainstdotfiles_v2/hyprland/.local/bin#perm-r:755/— all scripts now showperm:0755