refactor(config): centralize indexed item loading - #38
Merged
Merged
Conversation
Consolidate validation and duplicate detection for models, use cases, and workflows while preserving loader ordering and error contracts. Add characterization coverage for collection semantics, source paths, duplicate precedence, and workflow extension ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralize repeated config-item validation and duplicate detection in
load_orgwhile preserving every public YAML, ordering, and error contract.Changes
.yaml/.ymlordering semantics.Testing
.venv/bin/python -m pytest tests/test_store_config.py— 29 passed.venv/bin/python -m pytest tests/test_directory.py— 26 passed.venv/bin/ruff check src tests— passed.venv/bin/python -m pytest --cov=flightdeck --cov-fail-under=85— 231 passed, 93.92% coverage