refactor(engine): remove GitNexus integration + harden ask honesty - #88
Merged
Conversation
β¦ honesty Remove the optional GitNexus code-graph integration end to end β docs, skills, the MCP server entry, and engine code β so the project has zero GitNexus dependency or mention. The project's own internal knowledge graph (query_graph skill, knowledge_graph.json, .antigravity/graph) is unchanged. GitNexus removal: - ask_tools.py: drop _create_gitnexus_tools + the gitnexus CLI helpers - ask_pipeline.py: drop _query_graph_for_question and the needs_graph / GRAPH router decision + graph_section prompt injection (module routing and the internal query_graph skill are untouched) - refresh_pipeline.py: drop the Step 9 `gitnexus analyze` stage - README*.md / mcp_servers.json / demo-mock.sh: remove GitNexus sections Ask honesty (close two silent-failure holes): - tag auto-generated fallback agent.md docs and detect them at answer time so a degraded module is never served as factual knowledge β prepend a visible banner and steer the answer to live-source grounding - log before the previously silent `except: return None` sites on the ask path Also: remove the broken README hero demo.gif reference, delete the stale mission.md "downstream project" template note, and scope the legacy-MCP-name packaging test to real source (skip generated/local dirs). Tests: 219 passed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
β¦ build `packages = ["src/ag_cli"]` already includes src/ag_cli/templates, so the extra `force-include` re-added every template file at the same wheel path. Newer hatchling rejects duplicate archive paths (ValueError: a second file is being added ... `ag_cli/templates/.clinerules`), which failed `pip install ./cli` in the cli-check CI job (all Python versions). Removing the redundant force-include builds a clean wheel with all 12 templates present exactly once. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two cleanups in one pass.
1. Remove the optional GitNexus integration (zero dependency, zero mention)
_create_gitnexus_tools+ thegitnexusCLI helpers (live code-inspection tools kept)_query_graph_for_questionand theneeds_graph/GRAPH:router decision +graph_sectionprompt injection. Module routing and the project's own internalquery_graphskill /knowledge_graph.json/.antigravity/graphare untouched (those are not GitNexus).gitnexus analyzestage + its status handling2. Close two silent-failure holes on the ask path
_build_agent_md_fallbackwrites a bare file listing; the ask path previously read it as real knowledge. Now it's tagged (<!-- ag:status=fallback -->), detected at answer time, surfaced with a visible banner, and the answer is steered to live-source grounding. Regression test added (test_ask_fallback_detection.py).except: return Noneβ addedlogger.warningbefore the previously silent degrade points on the ask hot path.Also
demo.gifreference (file didn't exist;before_after.pngnow leads)mission.md"downstream project" template note.antigravity,.claude,artifacts,build)Tests
219 passed(full engine suite).π€ Generated with Claude Code