fix(mcp): constrain roots workspace upgrades to project scope - #83
Closed
study8677 wants to merge 1 commit into
Closed
fix(mcp): constrain roots workspace upgrades to project scope#83study8677 wants to merge 1 commit into
study8677 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_is_within_workspace(candidate, workspace)to test that a candidate root is the same as or a descendant of the original workspace._active_workspacebefore applying the upgrade.rootsby keeping the previous workspace and continuing to callreset_settings()on successful in-scope upgrades.Testing
pytest -q, which failed during test collection in this environment due toModuleNotFoundError: No module named 'ag_cli'(environment import issue unrelated to the change).pytest -q engine/tests/test_mcp_server_errors.py, which produced 5 passed and 1 failed due to the test environment lacking an async pytest plugin (pytest.mark.asynciounsupported), indicating the modified code exercised without regressions in the remaining assertions.Codex Task