fix(hub): prevent project-context symlink exfiltration - #81
Closed
study8677 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
_load_project_contextpreviously usedPath.is_file()andPath.read_text()which follow symlinks and can read files outside the workspace, allowing a malicious repo to cause exfiltration of host secrets into LLM prompts.Description
_load_project_contextinengine/antigravity_engine/hub/ask_pipeline.pyto resolve candidate paths and validate them withis_safe_path(workspace, resolved)before reading.read_text()usage with a bounded readerresolved.open().read(limit)that only reads up to the current per-source/budget slice.def _read_project_doc(path: Path) -> strto centralize resolve/validate/bounded-read logic and silently skip unsafe or unreadable sources.test_load_project_context_skips_symlink_outside_workspaceinengine/tests/test_hub_pipeline.pyto ensure symlinked project docs resolving outside the workspace are ignored.Testing
pytest -q engine/tests/test_hub_pipeline.py -k project_contextand the project-context-related tests passed (4 passed, 13 deselected) with only pytest mark warnings unrelated to the change.test_load_project_context_skips_symlink_outside_workspacewas executed and succeeded, verifying the symlink-exclusion behavior.Codex Task