feat: allow row editing

[GrbavaCigla]

Closes #97.

[aleksasiriski]

Great start, I haven't looked at everything yet but found a few questions :)

[GrbavaCigla]

The feature is done, only polishing left. I want to somehow try and display combo boxes for foreign keys.

[GrbavaCigla]

Also you don't have to review every change I make :) Save time and review it after I make draft a proper PR.

[aleksasiriski]

Looks very good, but next to the two comments I left:

• Enter while editing any field should submit the form (save changes)
• There should be a toast on successful change
• Form validation messages should appear under (or over, popover?) the fields when they're incorrect (instead of just a toast saying Invalid form input)
• There should be a way to cancel the edit (next to save button another cancel button)

[aleksasiriski]

If you need help with any of the requests please let me know :)

[GrbavaCigla]

• Form validation messages should appear under (or over, popover?) the fields when they're incorrect (instead of just a toast saying Invalid form input)
• Add a delete button
• Enter while editing any field should submit the form (save changes)
• There should be a toast on successful change
• There should be a way to cancel the edit (next to save button another cancel button)

[MikMik1011]

Feedback we got from the rectorate building;

• Identifiers should be editable because of typos
• Persons should be deletable due to duplicate entries with correct and wrong identifiers because persons identifiers cannot be edited

From the security side, regular users shouldn't be able to do this kind of major edits, since some rogue user could just delete or edit someones whole history, but I guess that admins could be trusted to do that, so maybe it can be a feature in admin panel?

[aleksasiriski]

From the security side, regular users shouldn't be able to do this kind of major edits, since some rogue user could just delete or edit someones whole history, but I guess that admins could be trusted to do that, so maybe it can be a feature in admin panel?

Perhaps there should be a simple dialog that asks for secret if the identifier is being changed. If it's untouched, no secret should be required.

[GrbavaCigla]

I can easily add a delete button along with the edit button.

[aleksasiriski]

Can you resolve conflicts with main?

Also, definately any edit should require a dialog that asks for admin secret

[aleksasiriski]

@GrbavaCigla Will you continue work on this?

There's was an idea to bring "admin sessions" to the app so that we can use better UIs for admins (tables with real data since it won't be public any more). Maybe this way we can make editing easier and restrict it only to admins, while also keeping the main search table clutterless.