Skip to content

ci(release-plz): gate releases on code commits, not data bumps#70

Open
polaz wants to merge 2 commits into
mainfrom
ci/#69
Open

ci(release-plz): gate releases on code commits, not data bumps#70
polaz wants to merge 2 commits into
mainfrom
ci/#69

Conversation

@polaz

@polaz polaz commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

release-plz was opening empty duplicate code-release PRs (e.g. #67) for PSL data bumps that are already published off-tag by the cascade.

Root cause (confirmed against release-plz docs): [changelog] commit_parsers skip only hides a commit from the changelog text — it does NOT stop release-plz from bumping the version when package files change. So skipping the data commit in commit_parsers (the first attempt) would not have suppressed the empty release.

Fix

  • .release-plz.toml: add release_commits = "^(feat|fix|perf|refactor|docs|test)" so release-plz opens a release PR only when a genuine code commit is present.
  • psl-cascade.yml: emit the data sync commit / sync-PR title as chore(data): ... (a dependency bump is a chore) so it does not match release_commits and never triggers a release-plz PR. Data releases remain fully handled off-tag by the cascade, which writes its own CHANGELOG entry.

Gating is by commit type, not scope, so a genuine feat(...) code change still releases normally (addresses the 'data scope hides code features' concern).

Effect

  • No empty/duplicate release PRs from data syncs
  • After merge, release-plz recomputes and drops the stale chore: release v0.0.17 #67
  • Genuine code changes still produce a release PR

Closes #69

PSL data bumps are released off-tag by the cascade, which writes their own
CHANGELOG entry. release-plz was treating the synced feat(data) commits as
unreleased features and opening empty duplicate code releases (version bump,
no changelog). Skip ^feat(data) so only genuine code changes trigger a
release PR.

Closes #69
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@polaz, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b3d9a7b3-cfd2-4305-9986-72cf47d3925c

📥 Commits

Reviewing files that changed from the base of the PR and between 61128c4 and a6553a7.

📒 Files selected for processing (1)
  • .release-plz.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/#69

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6553a7e55

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .release-plz.toml Outdated
@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown

Greptile Summary

This PR prevents cascade data updates from opening duplicate code-release PRs. The main changes are:

  • Classify generated PSL data commits and PR titles as chore(data).
  • Gate release-plz runs on selected code commit types.
  • Preserve releases for genuine feat(data) and fix(data) code changes.

Confidence Score: 5/5

This looks safe to merge.

The type-based gate preserves genuine feature and fix commits in the data scope. The cascade commit and PR title consistently use the excluded chore type. No blocking issues were found in the changed code.

T-Rex T-Rex Logs

What T-Rex did

  • The predecessor configuration lacked the release gate, as shown by EXIT_CODE: 1 in the before-state log.
  • I executed the release-commit-gating-proof.py harness to validate the gate logic against the plan.
  • The current configuration passes all gate cases, as shown by EXIT_CODE: 0 in the after-state log.
  • A verbose proof log captures the command, working directory, exit status, and per-evaluation results for inspection.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
.release-plz.toml Adds a commit-type release gate that excludes generated chores without excluding the full data scope.
.github/workflows/psl-cascade.yml Reclassifies generated data commits and sync PR titles from feature changes to chores.

Reviews (2): Last reviewed commit: "ci(release-plz): gate releases on code c..." | Re-trigger Greptile

Comment thread .release-plz.toml Outdated
commit_parsers skip only hides commits from the changelog text; it does NOT
stop release-plz from bumping the version on a package-file change, so the
cascade's data commit still produced an empty duplicate release. Add
release_commits so release-plz opens a release only when a genuine code commit
(feat/fix/perf/refactor/docs/test) is present, and emit the cascade data sync
as chore(data) so it never triggers one.
@polaz polaz changed the title ci(release-plz): skip cascade feat(data) commits ci(release-plz): gate releases on code commits, not data bumps Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(release-plz): skip cascade feat(data) commits so no empty code releases

1 participant