Conversation
PSL data bumps are released off-tag by the cascade, which writes their own CHANGELOG entry. release-plz was treating the synced feat(data) commits as unreleased features and opening empty duplicate code releases (version bump, no changelog). Skip ^feat(data) so only genuine code changes trigger a release PR. Closes #69
|
Warning Review limit reached
Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6553a7e55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
| Filename | Overview |
|---|---|
| .release-plz.toml | Adds a commit-type release gate that excludes generated chores without excluding the full data scope. |
| .github/workflows/psl-cascade.yml | Reclassifies generated data commits and sync PR titles from feature changes to chores. |
Reviews (2): Last reviewed commit: "ci(release-plz): gate releases on code c..." | Re-trigger Greptile
commit_parsers skip only hides commits from the changelog text; it does NOT stop release-plz from bumping the version on a package-file change, so the cascade's data commit still produced an empty duplicate release. Add release_commits so release-plz opens a release only when a genuine code commit (feat/fix/perf/refactor/docs/test) is present, and emit the cascade data sync as chore(data) so it never triggers one.
Summary
release-plz was opening empty duplicate code-release PRs (e.g. #67) for PSL data bumps that are already published off-tag by the cascade.
Root cause (confirmed against release-plz docs):
[changelog] commit_parsersskiponly hides a commit from the changelog text — it does NOT stop release-plz from bumping the version when package files change. So skipping the data commit in commit_parsers (the first attempt) would not have suppressed the empty release.Fix
.release-plz.toml: addrelease_commits = "^(feat|fix|perf|refactor|docs|test)"so release-plz opens a release PR only when a genuine code commit is present.psl-cascade.yml: emit the data sync commit / sync-PR title aschore(data): ...(a dependency bump is a chore) so it does not matchrelease_commitsand never triggers a release-plz PR. Data releases remain fully handled off-tag by the cascade, which writes its own CHANGELOG entry.Gating is by commit type, not scope, so a genuine
feat(...)code change still releases normally (addresses the 'data scope hides code features' concern).Effect
Closes #69