Skip to content

fix: preserve deployment cancellation details - #21

Merged
structName merged 1 commit into
mainfrom
codex/fix-deployment-cancel-ci
Jul 9, 2026
Merged

fix: preserve deployment cancellation details#21
structName merged 1 commit into
mainfrom
codex/fix-deployment-cancel-ci

Conversation

@structName

Copy link
Copy Markdown
Owner

Summary

  • avoid overwriting deployment stdout/stderr/progress when cancel and background cleanup update the same run concurrently
  • update only cancellation status and completion time, then reload the latest run for the API response
  • synchronize the cancellation regression test with executor startup so it tests the intended in-flight cancellation path

Root cause

The cancel handler saved a stale full-row deployment snapshot after cancelling the task context. If the background runner persisted context canceled first, the handler could overwrite stderr and other cleanup fields with empty values.

Validation

  • cancellation regression test: 100 consecutive runs
  • go test ./internal/api ./internal/database
  • go test ./...
  • npm --prefix web run build
  • scripts/check-deployment-sensitive-data.sh
  • git diff --check

@structName
structName merged commit b5a1244 into main Jul 9, 2026
1 check passed
@structName
structName deleted the codex/fix-deployment-cancel-ci branch July 9, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant