Reshape Checkout Session tax - #6922
Open
yuki-stripe wants to merge 4 commits into
Open
Conversation
yuki-stripe
requested review from
joyceqin-stripe
and removed request for
a team
August 14, 2026 03:35
yuki-stripe
force-pushed
the
yuki/checkout-session-status
branch
from
August 14, 2026 19:19
70c982c to
cec2851
Compare
yuki-stripe
force-pushed
the
yuki/checkout-session-tax
branch
from
August 14, 2026 19:23
161ad7f to
4f7c460
Compare
yuki-stripe
force-pushed
the
yuki/checkout-session-status
branch
from
August 14, 2026 23:17
cec2851 to
cbdfbc9
Compare
yuki-stripe
force-pushed
the
yuki/checkout-session-tax
branch
2 times, most recently
from
August 14, 2026 23:37
070a7b3 to
238473e
Compare
yuki-stripe
force-pushed
the
yuki/checkout-session-status
branch
from
August 14, 2026 23:41
cbdfbc9 to
a46686c
Compare
yuki-stripe
force-pushed
the
yuki/checkout-session-tax
branch
3 times, most recently
from
August 15, 2026 00:06
f86d8dc to
aa5802d
Compare
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
yuki-stripe
force-pushed
the
yuki/checkout-session-tax
branch
4 times, most recently
from
August 15, 2026 05:07
14babb3 to
6e8ad03
Compare
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
yuki-stripe
force-pushed
the
yuki/checkout-session-tax
branch
from
August 15, 2026 05:13
6e8ad03 to
ece7c54
Compare
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match the reviewed Checkout Elements API by separating tax computation state from aggregate tax amounts.
The Checkout Playground continues to use
totalsfor its compact order summary and exposes the namedtaxAmountsbreakdown from an info button in both UIKit and SwiftUI.taxAmountsdescribes the individual aggregate tax lines, whiletotalsgroups their values by tax treatment:Tax computation state maps as follows:
tax == nilmeans that no valid public computation status is available. It does not mean that no tax applies or that tax computation succeeded.Testing
CleanShot.2026-08-14.at.17.06.48.mp4
Added test coverage confirming:
nil, while an explicitly empty list remains empty.Manually verified the Checkout Playground tax summary and tax-details presentation in both UIKit and SwiftUI.
Stack
Depends on the Checkout Session status PR (
yuki/checkout-session-status).