SAE — add analytics - #6905
Draft
gbirch-stripe wants to merge 49 commits into
Draft
Conversation
Scopes the '(iOS) Dismissal Changes' work to the existing Address Element: X button becomes a pure cancel (confirm-on-changes via a Discard/Keep Editing alert, returning the as-presented address), swipe-to-dismiss is blocked, and the completion analytic fires only on an explicit save. Committed-By-Agent: claude
Committed-By-Agent: claude
Tapping 'X' now confirms before discarding unsaved changes and returns the as-presented address on cancel; swipe-to-dismiss is disallowed; the address completion analytic fires only on an explicit save. Committed-By-Agent: claude
…dismissal-changes
…e-ios into gbirch/ae-dismissal-changes
0 modified, 1 added
…-analytics Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> # Conflicts: # StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/AddressViewController/AddressViewController.swift # StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/AddressViewController/AddressViewControllerTests.swift
StripePaymentSheetPublic API+ @_Concurrency.MainActor @preconcurrency @objc dynamic public func presentationControllerShouldDismiss(_ presentationController: UIKit.UIPresentationController) -> Swift.BoolIf you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> # Conflicts: # StripePaymentSheet/StripePaymentSheet/Source/Analytics/STPAnalyticsClient+Address.swift # StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/AddressViewController/AddressViewController.swift # StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Checkout/Shipping Address Element/ShippingAddressElement.swift # StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/AddressViewController/AddressViewControllerSnapshotTests.swift # StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/AddressViewController/AddressViewControllerTests.swift # StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/Checkout/ShippingAddressElementPresentationTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog