Skip to content

Removed Vert.x from KafkaConnectRoller - #13205

Open
ppatierno wants to merge 1 commit into
strimzi:mainfrom
ppatierno:remove-vertx-kafkaconnectroller
Open

ppatierno wants to merge 1 commit into
strimzi:mainfrom
ppatierno:remove-vertx-kafkaconnectroller

Conversation

@ppatierno

Copy link
Copy Markdown
Member

Type of change

  • Refactoring

Description

This PR fixes #13200 by removing Vert.x from the KafkaConnectRoller class.

Checklist

  • Reference relevant issue(s) and close them after merging
  • Make sure all tests pass

Signed-off-by: Paolo Patierno <ppatierno@live.com>
@ppatierno ppatierno added this to the 1.3.0 milestone Sep 30, 2026
@ppatierno
ppatierno requested review from a team and tinaselenge September 30, 2026 12:59
@snyk-io

snyk-io Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ppatierno

Copy link
Copy Markdown
Member Author

/gha run pipeline=regression

@github-actions

Copy link
Copy Markdown

⏳ System test verification started: link
Waiting for build to finish...

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.76%. Comparing base (96eee24) to head (ad5be08).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13205      +/-   ##
============================================
- Coverage     80.80%   80.76%   -0.04%     
+ Complexity     6816     6811       -5     
============================================
  Files           360      360              
  Lines         23351    23350       -1     
  Branches       3173     3173              
============================================
- Hits          18868    18858      -10     
- Misses         3249     3253       +4     
- Partials       1234     1239       +5     
Files with missing lines Coverage Δ
...ter/operator/assembly/AbstractConnectOperator.java 88.91% <100.00%> (-0.26%) ⬇️
.../cluster/operator/assembly/KafkaConnectRoller.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Vert.x from KafkaConnectRoller

2 participants