Skip to content

Remove redundant debug log for cleaning up Certificate resource - #13193

Merged
tinaselenge merged 1 commit into
strimzi:mainfrom
tinaselenge:cert-removal-logging
Sep 29, 2026
Merged

tinaselenge merged 1 commit into
strimzi:mainfrom
tinaselenge:cert-removal-logging

Conversation

@tinaselenge

Copy link
Copy Markdown
Contributor

Type of change

  • Tidy up

Description

This line always gets logged when debug logging is enabled, even if there is no Certificate resource to delete therefore it doesn't add much value. It could also be confusing to users to see this log line, for example, if they are not running Cruise Control at all but would keep seeing log line saying operator is removing Certificate resource for it when it never actually existed.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Update documentation
  • Update CHANGELOG.md (if present)
  • Reference relevant issue(s) and close them after merging
  • Write tests
  • Make sure all tests pass
  • Try your changes inside a Kubernetes cluster, not just from unit tests
  • AI assistance was used to create this PR (see the Strimzi AI policy)

Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
@snyk-io

snyk-io Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.76%. Comparing base (d8b42c6) to head (9a42881).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13193      +/-   ##
============================================
+ Coverage     80.75%   80.76%   +0.01%     
- Complexity     6806     6808       +2     
============================================
  Files           360      360              
  Lines         23352    23351       -1     
  Branches       3174     3174              
============================================
+ Hits          18858    18860       +2     
+ Misses         3254     3253       -1     
+ Partials       1240     1238       -2     
Files with missing lines Coverage Δ
...a/io/strimzi/operator/common/ca/CertManagerCa.java 59.84% <ø> (-0.31%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scholzj scholzj added this to the 1.3.0 milestone Sep 28, 2026
@tinaselenge

Copy link
Copy Markdown
Contributor Author

@ppatierno @scholzj since this is just log line removal, can I merge it without running regression tests?

@scholzj

scholzj commented Sep 29, 2026

Copy link
Copy Markdown
Member

@ppatierno @scholzj since this is just log line removal, can I merge it without running regression tests?

Yes, I think you can merge it.

@tinaselenge
tinaselenge merged commit 8541d84 into strimzi:main Sep 29, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants