Remove redundant debug log for cleaning up Certificate resource - #13193
Merged
Merged
Conversation
Signed-off-by: Gantigmaa Selenge <tina.selenge@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13193 +/- ##
============================================
+ Coverage 80.75% 80.76% +0.01%
- Complexity 6806 6808 +2
============================================
Files 360 360
Lines 23352 23351 -1
Branches 3174 3174
============================================
+ Hits 18858 18860 +2
+ Misses 3254 3253 -1
+ Partials 1240 1238 -2
🚀 New features to boost your workflow:
|
scholzj
approved these changes
Sep 28, 2026
ppatierno
approved these changes
Sep 29, 2026
Contributor
Author
|
@ppatierno @scholzj since this is just log line removal, can I merge it without running regression tests? |
Member
Yes, I think you can merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This line always gets logged when debug logging is enabled, even if there is no Certificate resource to delete therefore it doesn't add much value. It could also be confusing to users to see this log line, for example, if they are not running Cruise Control at all but would keep seeing log line saying operator is removing Certificate resource for it when it never actually existed.
Checklist
Please go through this checklist and make sure all applicable tasks have been done