fix: restore the 4 fs_Hz regression tests dropped in the #63 merge resolution - #64
Merged
Conversation
…solution The refactor/engine-unification merge (#63) resolved the test_signal_domain.cpp conflict by keeping only the branch side, silently dropping the Combiner/Attenuator-manual/Equalizer/IdealFilter fs_Hz propagation tests added in #61 (T1). test_signal_domain went from 35 to 32 test cases on master. Re-apply the exact blocks as authored in ci/run-tests-on-pr (f18006e); suite is back to 36 cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
refactor/engine-unificationmerge (#63) resolved thetest_signal_domain.cppconflict keeping only the branch side, silently dropping the Combiner / Attenuator-manual / Equalizer / IdealFilter fs_Hz propagation tests added in #61 (T1 coverage for the #54 fix).test_signal_domainwent from 35 to 32 test cases on master.This re-applies the exact blocks as authored in
ci/run-tests-on-pr(f18006e).Verification: full build green;
test_signal_domain.exe36 test cases / 70 assertions, all pass (was 32/66 on master).