Skip to content

fix: inspector dirty-tracking marks edits in equalizer/attenuator/combiner/filter drawers #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
striderZA merged 2 commits into from
Aug 10, 2026
Merged

fix: inspector dirty-tracking marks edits in equalizer/attenuator/combiner/filter drawers #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e4729f
fix: inspector dirty-tracking marks edits in equalizer/attenuator/com…
Aug 10, 2026
8a3a83b
Merge master into fix/ui-state: resolve engine-unification overlap (k…
striderZA Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions app/src/inspector_panel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,10 @@ void InspectorPanel::drawAmplifierProperties(AmplifierEngine &engine, int index)
ImGui::EndDisabled();
} else {
double gain = engine.gain_dB();
if (utils::inputDouble("Gain (dB)", gain, 1, 10, "%.1f", -10.0, 40.0))
if (utils::inputDouble("Gain (dB)", gain, 1, 10, "%.1f", -10.0, 40.0)) {
engine.setGain_dB(gain);
m_param_edited = true;
m_param_edited = true;
}
}

double nf = engine.nf_dB();
Expand Down Expand Up @@ -483,6 +484,7 @@ void InspectorPanel::drawEqualizerProperties(EqualizerEngine &engine, int index)
int eq_mode_idx = engine.sparamMode() ? 1 : 0;
if (ImGui::Combo("##eq_mode", &eq_mode_idx, eq_modes, IM_ARRAYSIZE(eq_modes))) {
engine.setSParamMode(eq_mode_idx == 1);
m_param_edited = true;
}

if (engine.sparamMode()) {
Expand All @@ -493,6 +495,7 @@ void InspectorPanel::drawEqualizerProperties(EqualizerEngine &engine, int index)
.result();
if (!result.empty()) {
engine.setSParamFilepath(result[0]);
m_param_edited = true;
}
}
if (engine.sparamLoaded()) {
Expand All @@ -505,16 +508,22 @@ void InspectorPanel::drawEqualizerProperties(EqualizerEngine &engine, int index)
}

double ref_gain = engine.refGain_dB();
if (utils::inputDouble("Ref Gain (dB)", ref_gain, 1, 10, "%.1f", -40.0, 40.0))
if (utils::inputDouble("Ref Gain (dB)", ref_gain, 1, 10, "%.1f", -40.0, 40.0)) {
engine.setRefGain_dB(ref_gain);
m_param_edited = true;
}

double ref_freq = engine.refFreq_Hz();
if (utils::inputFrequency("Ref Freq (MHz)", ref_freq, 1.0, 100.0, "%.0f", 1.0, 100e9))
if (utils::inputFrequency("Ref Freq (MHz)", ref_freq, 1.0, 100.0, "%.0f", 1.0, 100e9)) {
engine.setRefFreq_Hz(ref_freq);
m_param_edited = true;
}

double slope = engine.slope_dBPerDecade();
if (utils::inputDouble("Slope (dB/dec)", slope, 0.1, 1.0, "%.1f", -100.0, 100.0))
if (utils::inputDouble("Slope (dB/dec)", slope, 0.1, 1.0, "%.1f", -100.0, 100.0)) {
engine.setSlope_dBPerDecade(slope);
m_param_edited = true;
}

if (engine.sparamMode())
ImGui::EndDisabled();
Expand All @@ -539,6 +548,7 @@ void InspectorPanel::drawIdealFilterProperties(IdealFilterEngine &engine, int in
int f_mode_idx = engine.sparamMode() ? 1 : 0;
if (ImGui::Combo("##filter_mode", &f_mode_idx, filter_modes, IM_ARRAYSIZE(filter_modes))) {
engine.setSParamMode(f_mode_idx == 1);
m_param_edited = true;
}

if (engine.sparamMode()) {
Expand All @@ -549,6 +559,7 @@ void InspectorPanel::drawIdealFilterProperties(IdealFilterEngine &engine, int in
.result();
if (!result.empty()) {
engine.setSParamFilepath(result[0]);
m_param_edited = true;
}
}
if (engine.sparamLoaded()) {
Expand Down Expand Up @@ -602,11 +613,13 @@ void InspectorPanel::drawAttenuatorProperties(AttenuatorEngine &engine, int inde
float atten_f = static_cast<float>(engine.attenuation());
if (ImGui::DragFloat("Atten (dB)", &atten_f, 0.1f, 0.0f, 200.0f)) {
engine.setAttenuation(static_cast<double>(atten_f));
m_param_edited = true;
}

bool sparam_mode = engine.sparamMode();
if (ImGui::Checkbox("S-param mode", &sparam_mode)) {
engine.setSParamMode(sparam_mode);
m_param_edited = true;
}

if (sparam_mode) {
Expand All @@ -616,6 +629,7 @@ void InspectorPanel::drawAttenuatorProperties(AttenuatorEngine &engine, int inde
path_buf[sizeof(path_buf) - 1] = '\0';
if (ImGui::InputText("S-param file", path_buf, sizeof(path_buf))) {
engine.setSParamFilepath(path_buf);
m_param_edited = true;
}
}

Expand All @@ -633,6 +647,7 @@ void InspectorPanel::drawCombinerProperties(CombinerEngine &engine, int index) {
bool sparam_mode = engine.sparamMode();
if (ImGui::Checkbox("S-parameter mode", &sparam_mode)) {
engine.setSParamMode(sparam_mode);
m_param_edited = true;
}

if (sparam_mode) {
Expand All @@ -642,6 +657,7 @@ void InspectorPanel::drawCombinerProperties(CombinerEngine &engine, int index) {
path_buf[sizeof(path_buf) - 1] = '\0';
if (ImGui::InputText("S-param file", path_buf, sizeof(path_buf))) {
engine.setSParamFilepath(path_buf);
m_param_edited = true;
}
}

Expand Down