Remove chardet library - #122
Open
opsdisk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @stricaud,
From my testing, the
chardetlibrary is not used within faup. A search ofchardetwithin the repo yielded only 2 results, so I removed all instances of it and it functionally still worked. Side note, I also opened a ticket earlier this year about financially supporting the library (#116) - it's a great library!Removed
chardetin the 2 files. Note when usingpip installto pull from pypi,chardetis not even installed and must be manually installed.Installed the library using
python setup.py installRan the following commands to test it and it seemed fine