Skip to content

fix(ci): use existing sherpa-onnx CUDA GPU archive name #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
streamer45 merged 1 commit into from
Jul 5, 2026
Merged

fix(ci): use existing sherpa-onnx CUDA GPU archive name #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/marketplace-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ env:
SHERPA_ONNX_VERSION: "1.12.17"
# GPU (CUDA-enabled) sherpa-onnx shared build; vendored into cuda variants so
# the execution-provider-agnostic plugin .so dispatches to the GPU at runtime.
SHERPA_ONNX_GPU_ARCHIVE: "sherpa-onnx-v1.12.17-linux-x64-gpu-shared.tar.bz2"
SHERPA_ONNX_GPU_ARCHIVE: "sherpa-onnx-v1.12.17-cuda-12.x-cudnn-9.x-linux-x64-gpu.tar.bz2"

@staging-devin-ai-integration staging-devin-ai-integration Bot Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 New GPU archive name relies on basename==extracted-dir convention

The change updates SHERPA_ONNX_GPU_ARCHIVE to sherpa-onnx-v1.12.17-cuda-12.x-cudnn-9.x-linux-x64-gpu.tar.bz2. The download/extract step at .github/workflows/marketplace-build.yml:261-265 derives the extracted directory generically via dir="${SHERPA_ONNX_GPU_ARCHIVE%.tar.bz2}", so it adapts to the rename automatically. This is only correct if the CUDA tarball extracts to a top-level directory whose name exactly matches the archive basename (sherpa-onnx-v1.12.17-cuda-12.x-cudnn-9.x-linux-x64-gpu). If the k2-fsa release uses a different internal directory layout, the cp -r "${dir}/lib/." step would fail. Worth a quick confirmation against the actual release asset, since it can't be verified from the code alone.

Open in Devin Review (Staging)

Was this helpful? React with 👍 or 👎 to provide feedback.

Debug

Playground

@staging-devin-ai-integration staging-devin-ai-integration Bot Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against the actual release asset: downloaded sherpa-onnx-v1.12.17-cuda-12.x-cudnn-9.x-linux-x64-gpu.tar.bz2 and its top-level directory is exactly the archive basename, with lib/ containing libsherpa-onnx-c-api.so, libonnxruntime.so, libonnxruntime_providers_cuda.so, and libonnxruntime_providers_shared.so — everything the bundle vendoring needs.

MINISIGN_DEB_URL: "http://launchpadlibrarian.net/780165111/minisign_0.12-1_amd64.deb"
REGISTRY_BASE_URL: ${{ inputs.registry_base_url || 'https://streamkit.dev/registry' }}

Expand Down
Loading