fix: avoid GHCR dependency in dashboard build - #55
Open
eldraco wants to merge 5 commits into
Open
Conversation
Collaborator
|
What is the motivation behind these changes @eldraco? The commit fix: reuse local images when starting plugins is not good because it does not allow me to fix classes/changes during semester. Students would be stuck with the old wrong image because the image would be never rebuilt without some manual image deletion performed by students. So the original step to always check if build context changed was on purpose. If the build context was not changed, cache layers are used and there's no problem. So I don't think we want this change. The same effect applies for plugins. The second commit might be okay with a drawback that we are not checking checksum of the dependency. What is the issue in your computer with ghcr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv==0.12.9package from PyPI instead of copying the binary from a GHCR imageup -d --buildso changed build contexts are detectedMotivation
The dashboard build failed while resolving the pinned
ghcr.io/astral-sh/uvimage because the GHCR token request was denied. This prevented SCL itself from building. Installing the same pinned uv version through the Python package index avoids that additional registry dependency.The later Docker Hub timeout on Kilimanjaro was a separate host networking problem and is not a reason to disable plugin builds.
Tradeoff
This pins the uv version but does not commit an explicit artifact checksum. The previous GHCR reference pinned an image digest. If an explicit package hash is required, we should add architecture-specific wheel hashes rather than skip plugin rebuilds.
Validation
docker compose build dashboardcompleted successfully--buildpath and returned HTTP 200healthy, version1.0.2git diff --check