Skip to content

WIP: Default Security Context #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
strangiato wants to merge 3 commits into
base: main
Choose a base branch
from
Open

WIP: Default Security Context #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6fcc74
add sc settings to oauth proxy pod
strangiato Jan 18, 2023
d6d49da
setup default sc settings
strangiato Jan 18, 2023
64080b6
add default sc to tests
strangiato Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charts/mlflow-server/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ spec:
{{- toYaml .Values.resources | nindent 12 }}
{{- if .Values.openshiftOauth.enabled }}
- name: oauth-proxy
image: registry.redhat.io/openshift4/ose-oauth-proxy:v4.10
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: registry.redhat.io/openshift4/ose-oauth-proxy:v4.11
imagePullPolicy: IfNotPresent
ports:
- containerPort: 8443
Expand Down
6 changes: 6 additions & 0 deletions charts/mlflow-server/templates/tests/test-connection.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ metadata:
spec:
containers:
- name: wget
securityContext:
allowPrivilegeEscalation: false
runAsNonRoot: true
capabilities:
drop:
- ALL
image: busybox
command: ['wget']
args: ['{{ include "mlflow-server.fullname" . }}:{{ .Values.service.port }}']
Expand Down
6 changes: 6 additions & 0 deletions charts/mlflow-server/templates/tests/test-training.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ metadata:
spec:
containers:
- name: training
securityContext:
allowPrivilegeEscalation: false
runAsNonRoot: true
capabilities:
drop:
- ALL
image: "{{ .Values.trainingTestImage.repository }}:{{ .Values.trainingTestImage.tag | default .Chart.AppVersion }}"
imagePullPolicy: "{{ .Values.trainingTestImage.pullPolicy}}"
env:
Expand Down
18 changes: 9 additions & 9 deletions charts/mlflow-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ podAnnotations: {}

# --
podSecurityContext: {}
# fsGroup: 2000

securityContext: {}
# capabilities:
# drop:
# - ALL
# readOnlyRootFilesystem: true
# runAsNonRoot: true
# runAsUser: 1000
# seccompProfile:
# type: RuntimeDefault

securityContext:
allowPrivilegeEscalation: false
runAsNonRoot: true
capabilities:
drop:
- ALL

objectStorage:
objectBucketClaim:
Expand Down