Skip to content

Drop page thumbnails - #1346

Closed
not-a-feature wants to merge 3 commits into
storytold:mainfrom
not-a-feature:codex/redaction-thumbnails
Closed

not-a-feature wants to merge 3 commits into
storytold:mainfrom
not-a-feature:codex/redaction-thumbnails

Conversation

@not-a-feature

@not-a-feature not-a-feature commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Split from #1151 as suggested in review.

Applying redaction removes /Thumb from selected pages so the old preview cannot disclose removed content. Unselected previews stay intact. Rebased on main after #1351; the shared helper is kept once and the roadmap entry is a table row.

Full Linux workspace tests pass (2770 passed, 13 ignored), with CI's pinned craft-fonts input and the low-disk profile.

@not-a-feature not-a-feature changed the title WIP: Drop redacted page thumbnails WIP: Drop page thumbnails Oct 12, 2026
@echelon

echelon commented Oct 12, 2026

Copy link
Copy Markdown
Member

Thanks, @not-a-feature: this looks correct and small. #1351 has landed, so this needs a rebase (ROADMAP tail, docs/roadmap.md M8 row, and the shared test helper). Also, the ROADMAP log is a table now, so the entry should be a table row rather than a bullet. Mark it ready when you're happy with it and I'll land it.

Please join us on Discord if you haven't already: https://discord.gg/artcraft

@not-a-feature
not-a-feature force-pushed the codex/redaction-thumbnails branch from a788035 to b64dd88 Compare October 12, 2026 11:37
@not-a-feature not-a-feature changed the title WIP: Drop page thumbnails Drop page thumbnails Oct 12, 2026
@not-a-feature
not-a-feature marked this pull request as ready for review October 12, 2026 11:37
@not-a-feature

Copy link
Copy Markdown
Contributor Author

Rebased on main and addressed review. Local Linux workspace tests passed on b64dd88: 2770 passed, 13 ignored. Formatting and workspace Clippy pass too. Ran cargo test --workspace --locked --profile low-disk --no-fail-fast with CI's pinned craft-fonts input.

@not-a-feature

Copy link
Copy Markdown
Contributor Author

Merged current main and resolved the conflicts, keeping both upstream resource-cleanup tests and this PR's regressions. Formatting, cargo test -p pdfcraft-redact --locked and targeted Clippy pass on cbd3019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants