Repository navigation
Recognize pound currency and preserve CSV numeric precision - #468
Closed
derechopiano wants to merge 2 commits into
Closed
derechopiano wants to merge 2 commits into
derechopiano wants to merge 2 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing
£5now stores numeric5with pound formatting, so=A1*2produces10. The existing dollar parser also recognizes pounds in negative/grouped amounts and numeric-text arithmetic; apostrophe-prefixed input remains text.A separate follow-up commit repairs the failures also present in upstream main CI:
Validation:
FormulaLocalin Windows Excel 16.0 build 20326 using an unsaved synthetic workbook.cargo xtask cipasses locally: all eight gates, 1,330 tests passed and one existing ignored test. No test filters or new exclusions. Generated-file checks ran on LF files, matching the committed files and Linux CI.No Excel-produced files or assets are included. This extends the existing input syntax; it does not implement a complete locale-dependent parser.
Related work: #447 — regional formats adds region-dependent currency parsing and overlaps this PR's shared input parser. This PR accepts pounds alongside the existing dollar syntax independently of region; it should be reconciled with #447 rather than treated as universal Excel currency-recognition behaviour. Further euro/yen support belongs in that regional-design discussion.