Repository navigation
Draw tab: pen buttons show their colour and thickness (labels and icons) - #1791
Closed
alosslessdev wants to merge 1 commit into
Closed
alosslessdev wants to merge 1 commit into
alosslessdev wants to merge 1 commit into
Conversation
This was referenced Oct 17, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1784.
The Draw tab's pens now show what they draw: Excel-style labels with colour and thickness, and icons painted in the pen's ink colour with a distinct highlighter shape.
What changed
crates/ui-egui/src/ribbon.rs): each pen readsPen: Blue, 2 pt,Pen: Black, 2 pt,Pen: Red, 2 pt,Highlighter: Yellow, 12 pt(Excel'sPen: Black, 0.35 mmshape; GridCraft's unit is points). The active pen shows its current width;pt_labelformats whole and half values.icons.rs,widgets.rs): the pen glyph is drawn in the pen's ink colour through a newbig_button_tinted(the plainbig_buttonkeeps its signature), and a newIcon::Highlighterdraws a broad marker with a chisel nib so the highlighter no longer looks like a pen. The highlighter is tinted yellow.Order, menus and the live preview are unchanged; they are separate PRs (#1783, #1785, #1786). Cut from
main, independent of #1767/#1187.Verification
cargo fmt --all -- --checkcargo clippy -p gridcraft-ui-egui --all-targets -- -D warningscargo test -p gridcraft-ui-egui(full crate suite)--example snapshot -- --tab Draw): blue/black/red pen glyphs in their ink colours, a yellow highlighter marker, and the labels with colour and thickness.docs/ui-parity.mdrevision history updated;contributors/people.tomlentry perAGENTS.md.