Repository navigation
Conversation
HyakoV3
force-pushed
the
fix/1447-pivot-headers-chart
branch
from
October 16, 2026 00:38
62f6cae to
5378d4f
Compare
HyakoV3
marked this pull request as ready for review
October 16, 2026 00:39
…ainsString="0" next to them made Excel refuse the file); a date group with a blank date no longer writes containsSemiMixedTypes; date groups are written without sortType and read back ascending; a single-item report filter is read through the field's items; two value fields without a column field write firstHeaderRow=0 and hideValuesRow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nk names the workbook A header with a leading or trailing space is kept as it is in the pivot source and cache, and a command naming Region still finds 'Region ' when it is the only match. A PivotChart's link to its PivotTable is written behind the workbook in brackets (file name, or Workbook.xlsx when unknown), so Excel binds the chart to the table. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
HyakoV3
force-pushed
the
fix/1447-pivot-headers-chart
branch
from
October 16, 2026 00:40
5378d4f to
3c11c3b
Compare
7 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items 2 and 7 of #1447. Stacked on #1538 (items 1, 3–6, same file): review the last commit only; I'll rebase and mark this ready when #1538 merges. With both, #1447 is complete.
engine/src/pivot.rs) and the cache (header_text) keep a header as it is, as Excel does; only an all-blank header is an error /ColumnN.Source::colmatches the exact header (case-insensitive) first, then a trimmed comparison when exactly one header matches, so a command namingRegionstill findsRegion. Before, the fields vanished on open + save and on refresh.[Book.xlsx]Sheet2!PivotTable1; Excel only binds the chart to its PivotTable behind a bracketed workbook. Newgridcraft_xlsx::write_xlsx_namedcarries the file name towrite_chart(save_bytes_aspasses the path's file name;file.saveBytesthe document's name);[Workbook.xlsx]when unknown or when the name holds[/]. The reader drops the bracket prefix, so the model link staysSheet2!PivotTable1.Tests (
crates/engine/tests/pivot_headers_and_chart_link.rs, both fail onmain): a pivot overRegion/Saleskeeps 1 row and 2 value fields through create, XLSX save, reopen and refresh; the saved chart holds[Q1 Report.xlsx]Sheet2!PivotTable1and reads back asSheet2!PivotTable1.cargo xtask cipasses.🤖 Generated with Claude Code