Repository navigation
Conversation
haranishi
marked this pull request as ready for review
October 14, 2026 12:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Japanese selected, existing Format Cells, PivotTable Fields and printer settings still showed English. This adds 229 Japanese entries to their current lookup paths, taking the catalog from 398 to 627 entries.
Outlineinto外枠andアウトライン形式. Only those two context keys fall back to the existing plain key, preserving every other interface language and English. The regression test covers all 11 current languages.Validation:
cargo xtask cipasses all eight gates: fmt, clippy, test, assets, layers, wasm, parity and keytips. 1,600 tests passed, zero failed, one existing default ignored test.d97baccf29f4083419e650a6e4682cb19bdc9479); 1,600 passed, zero failed, one default ignored test. Upstream Actions await maintainer approval.git diff --checkis clean.outlinelayout and grayscale state. A synthetic receipt containing braces remains unchanged in the UI and API.Scope: ordinary custom dialog bodies and several baseline labels remain English; this does not duplicate the broader dialog drawing work in #669. Pending Japanese additions and shortcut/Draw labels replaced by active feature PRs are excluded. #191 is a reference-only draft whose author does not intend to merge it.
The print check uses synthetic discovery/feedback and submits no physical job. Live print controls/status return to English after switching languages; an already-created transient Japanese toast keeps its cached text until expiry. Other platforms, narrow windows and IME input were not exercised.