Skip to content

i18n: expand Japanese dialogs, panes, menus and print controls - #1287

Open
haranishi wants to merge 1 commit into
storytold:mainfrom
haranishi:codex/japanese-ui-followup-20261014
Open

haranishi wants to merge 1 commit into
storytold:mainfrom
haranishi:codex/japanese-ui-followup-20261014

Conversation

@haranishi

@haranishi haranishi commented Oct 14, 2026 •

Copy link
Copy Markdown

With Japanese selected, existing Format Cells, PivotTable Fields and printer settings still showed English. This adds 229 Japanese entries to their current lookup paths, taking the catalog from 398 to 627 entries.

  • Translate existing Format Cells controls, dialog titles, PivotTable Fields, print settings and feedback, plus selected menus and tooltips. Keep the shared 398-entry Japanese catalog and its coverage checks unchanged.
  • Separate the border and report-layout meanings of Outline into 外枠 and アウトライン形式. Only those two context keys fall back to the existing plain key, preserving every other interface language and English. The regression test covers all 11 current languages.
  • Preserve command/control IDs, tab names, canonical pivot values, format tokens, workbook text, printer names and backend receipt/error data. Update the measured coverage docs without claiming a complete Japanese interface.

Validation:

  • cargo xtask ci passes all eight gates: fmt, clippy, test, assets, layers, wasm, parity and keytips. 1,600 tests passed, zero failed, one existing default ignored test.
  • The fork CI run also passes all eight gates for this exact PR head (d97baccf29f4083419e650a6e4682cb19bdc9479); 1,600 passed, zero failed, one default ignored test. Upstream Actions await maintainer approval.
  • Static review and catalog/placeholder checks pass with no unresolved findings; git diff --check is clean.
  • Eight 2× offscreen views were checked using native Linux Noto CJK fallback: Home, Format Cells Number/Border/Protection, Pivot fields/layout menu, and Japanese/English print controls. Native clicks verify border controls, the canonical outline layout and grayscale state. A synthetic receipt containing braces remains unchanged in the UI and API.

Scope: ordinary custom dialog bodies and several baseline labels remain English; this does not duplicate the broader dialog drawing work in #669. Pending Japanese additions and shortcut/Draw labels replaced by active feature PRs are excluded. #191 is a reference-only draft whose author does not intend to merge it.

The print check uses synthetic discovery/feedback and submits no physical job. Live print controls/status return to English after switching languages; an already-created transient Japanese toast keeps its cached text until expiry. Other platforms, narrow windows and IME input were not exercised.

@haranishi
haranishi marked this pull request as ready for review October 14, 2026 12:14
Copilot AI balanced review requested due to automatic review settings October 14, 2026 12:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants