Skip to content

Ribbon: more currency symbols in the Accounting Number Format menu - #1068

Open
marcoarnulfo wants to merge 1 commit into
storytold:mainfrom
marcoarnulfo:fix/more-currency-symbols
Open

marcoarnulfo wants to merge 1 commit into
storytold:mainfrom
marcoarnulfo:fix/more-currency-symbols

Conversation

@marcoarnulfo

@marcoarnulfo marcoarnulfo commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1063.

The Accounting Number Format menu on the Home tab offered four symbols, but the number formatter already renders any [$symbol-LCID] tag, so the gap was only the list. This moves the menu entries into one ACCOUNTING_SYMBOLS table and adds the currencies from the issue with Excel's codes: Rp Indonesian ([$Rp-421]), ₹ English (India) ([$₹-4009]), ₩ Korean ([$₩-412]) and ¥ Chinese (PRC) ([$¥-804]), plus CHF German (Switzerland), R$ Portuguese (Brazil) and ₽ Russian. Each one uses the same accounting layout as the existing £ entry. The codes are plain custom number formats, so they go through XLSX like any other.

A few notes, happy to switch on any of them:

  • ₩ Korean has no decimals, like the existing ¥ Japanese, because neither currency has a minor unit. The others have two.
  • On the web build, the UI falls back to egui's own fonts, which have no ₩ or ₽, so those two show as a box there, the same limit CJK and Thai text already has. On desktop the system UI font draws them (checked on macOS).
  • Thousands and decimal separators (Rp1.234,50 in Indonesian use) come from the regional settings rather than the symbol, as in Excel, so they belong with M12: regional formats (typed and displayed numbers, dates and times) #447.
  • The new labels are not in the Czech and Portuguese catalogs yet (the only ones that translate this menu). I left them out to stay clear of M12: regional formats (typed and displayed numbers, dates and times) #447, which edits those files, and can add them in a follow-up.

Validation:

  • ribbon::accounting_symbol_tests::accounting_dropdown_offers_the_issue_currencies_with_excel_codes: fails on main (Rp Indonesian is not in the Accounting dropdown), passes here. It checks that each currency from the issue is in the menu with its Excel tag and that 1234.5 shows as Rp1,234.50, ₹1,234.50, ¥1,234.50, ₩1,235 (with the fill right after the symbol)
  • cargo clippy -p gridcraft-ui-egui --all-targets -- -D warnings, cargo fmt --all -- --check
  • (macOS, Apple silicon)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More currency symbols in cell number format (e.g. IDR / Rp)

1 participant