Repository navigation
Ribbon: more currency symbols in the Accounting Number Format menu - #1068
Open
marcoarnulfo wants to merge 1 commit into
Open
marcoarnulfo wants to merge 1 commit into
marcoarnulfo wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1063.
The Accounting Number Format menu on the Home tab offered four symbols, but the number formatter already renders any
[$symbol-LCID]tag, so the gap was only the list. This moves the menu entries into oneACCOUNTING_SYMBOLStable and adds the currencies from the issue with Excel's codes:Rp Indonesian([$Rp-421]),₹ English (India)([$₹-4009]),₩ Korean([$₩-412]) and¥ Chinese (PRC)([$¥-804]), plusCHF German (Switzerland),R$ Portuguese (Brazil)and₽ Russian. Each one uses the same accounting layout as the existing £ entry. The codes are plain custom number formats, so they go through XLSX like any other.A few notes, happy to switch on any of them:
₩ Koreanhas no decimals, like the existing¥ Japanese, because neither currency has a minor unit. The others have two.Rp1.234,50in Indonesian use) come from the regional settings rather than the symbol, as in Excel, so they belong with M12: regional formats (typed and displayed numbers, dates and times) #447.Validation:
ribbon::accounting_symbol_tests::accounting_dropdown_offers_the_issue_currencies_with_excel_codes: fails on main (Rp Indonesian is not in the Accounting dropdown), passes here. It checks that each currency from the issue is in the menu with its Excel tag and that 1234.5 shows asRp1,234.50,₹1,234.50,¥1,234.50,₩1,235(with the fill right after the symbol)cargo clippy -p gridcraft-ui-egui --all-targets -- -D warnings,cargo fmt --all -- --check