You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Quotes are stripped from sheet names in about eight places, each with its own copy #2012
Several places strip the quotes of a sheet name and read '' as ' with separate hand-written copies, which disagree on edge cases. They should share one unquote_sheet / split_sheet in core.
Split out of #1458 as requested there. Fixed by #1529.
Mostly fixed by #1529; a few separate copies of the unquoting remain
Checked on maind8c5f58 (gridcraft-cli 0.12.1, dev build, Linux) and in Excel (Microsoft 365, Windows, build 16.0.20527).
What I checked:quote_sheet, unquote_sheet and split_sheet now exist once, in crates/core/src/addr.rs, and unquote_sheet is the only place that turns '' into ' (grep for replace("''" finds that one). The behaviour checks for the sibling issues #2009, #2010 and #2013 are in my notes there.
Still separate: a few other places strip quotes themselves with trim_matches('\''), which doesn't read '' as one apostrophe: sheet-qualified defined names in chart references (crates/xlsx/src/chart.rschart_name, crates/chart/src/resolve.rsis_defined_name) and crates/xlsx/src/ods.rs. I only read these, I didn't run a workbook through them, so I can't say whether a name on a sheet like Bob's fails there. The one in engine/src/io.rs is for the CSV file name and is unrelated.
Whether that remainder is within the issue's "about eight places" is for the maintainers to judge.
Activity
ticket-craft commentedon Oct 19, 2026
Possibly related: #1458, #2013 and #2009.
Harrison-Booth commentedon Oct 26, 2026
Mostly fixed by #1529; a few separate copies of the unquoting remain
Checked on
maind8c5f58 (gridcraft-cli 0.12.1, dev build, Linux) and in Excel (Microsoft 365, Windows, build 16.0.20527).What I checked:
quote_sheet,unquote_sheetandsplit_sheetnow exist once, incrates/core/src/addr.rs, andunquote_sheetis the only place that turns''into'(grepforreplace("''"finds that one). The behaviour checks for the sibling issues #2009, #2010 and #2013 are in my notes there.Still separate: a few other places strip quotes themselves with
trim_matches('\''), which doesn't read''as one apostrophe: sheet-qualified defined names in chart references (crates/xlsx/src/chart.rschart_name,crates/chart/src/resolve.rsis_defined_name) andcrates/xlsx/src/ods.rs. I only read these, I didn't run a workbook through them, so I can't say whether a name on a sheet likeBob'sfails there. The one inengine/src/io.rsis for the CSV file name and is unrelated.Whether that remainder is within the issue's "about eight places" is for the maintainers to judge.