Repository navigation
Translate remaining Japanese panel labels - #1772
Merged
bflatastic merged 5 commits intoOct 30, 2026
Merged
Conversation
Two English surfaces the translation work so far could not reach. The dock's tab titles: `PanelKind::title()` is drawn by `dock_ui.rs`'s `tab_titles`, which listed only the tabs that name a comp, a layer or a script and let every other one fall back to `title()`'s English - so every panel tab (`Timeline`, `Preview`, `Properties`, `Effects & Presets`, ...) stayed English. The Window menu already carries a (`window.panel`, title) row in every catalog, so the dock reads that pair and falls back to the panel catalog for `Markers` (the one panel only it names); `History` and `ScriptUI Panel` have no row anywhere and keep their English names. `app.auto`'s labels and the dock's serialized state keep the English title, which the control channel needs. The scan's blind shapes: `converted_panels_have_no_unwrapped_literals` only sees a literal that follows a call token, so a label passed to a helper, the third argument of `Painter::text`, a `(key, label, ...)` table, a `let` binding and a `match` arm were all invisible. The two that can be checked without guessing are added (`helper_and_painter_labels_are_translated`), with the same single-character exemption the call scan makes, and the 25 sites they find now ask the catalog (`Apply`, `Analyze`, `Cancel`, `Create Camera`, `Add Point`, `Remove Point`, `Clear`, `Render`, `Stop`, `Save Current as Template...`, `New Composition From Footage`, the three search fields, `(no composition)`, `per second`, `Waveform`, `steps`), with 15 rows added to the Simplified and Traditional catalogs in the conventions those tables already use (Render 算圖, Apply 套用, Add Point 添加點). The `uic!` labels and the Keyboard Shortcuts dialog are a different shape and are still to decide (storytold#1451). Verified on Linux: cargo fmt --all --check, cargo test -p effectcraft-ui-egui (every suite passes), cargo clippy -p effectcraft-ui-egui --all-targets -- -D warnings clean. Reverting the dock's catalog lookup fails `the_dock_draws_every_panel_it_can_in_the_interface_language`; unwrapping a helper or a painter label fails `helper_and_painter_labels_are_translated` ("panels/project.rs:434: the interface text \"Search project\" that widgets::search_field draws is not in the catalog").
haranishi
changed the title
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Add Japanese panel translations crates/ui-egui/src/i18n/ui.rs |
The Japanese catalog adds translations for 13 panel labels and messages. These include action labels, search text, composition status, and waveform terminology. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Feature
Suggested reviewers: aiongg
Merge Risk: 
d2bc8
-
The localization additions are scoped correctly and introduce no identified merge-blocking risk.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: adding the remaining Japanese translations for panel labels. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
haranishi
marked this pull request as ready for review
October 30, 2026 03:54
Member
|
Merged, thank you @haranishi! It landed on |
bflatastic
added a commit
to zitann2020/effectcraft
that referenced
this pull request
Oct 30, 2026
…one source string per table)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1581 has merged. This branch now normally merges
mainata934abff07299288b596b0fdfdff945c4fb591e8and adds the thirteen remaining Japanese panel-label translations.The comparison against that main is exactly thirteen added rows in
crates/ui-egui/src/i18n/ui.rs. The two original rows already upstream, “Create Camera” and “Search effects and presets”, remain unchanged. The original prerequisite commits and authorship remain in the branch history, and current main's wiring and other language catalogs are retained.The labels cover panel actions, searches, the empty-composition label, Waveform and the Learn step count. The template button retains the compact
テンプレートとして保存…wording. The toolbar-name translations assigned elsewhere remain outside this change.Validation on the final merged source:
cargo fmt --all --checkand the main-relativegit diff --check: passed.i18n/ui.rswith a small Rust wrapper. This covers lookup, unique keys, placeholder shape and current source consumers.cargo xtask ci, workspace Clippy and a fresh native/UI visual run were not run on this merged tree. The retained cache lacks the pinned egui revision, so even an offline lightweight xtask command stops during dependency resolution; a cold workspace build would exceed the available SSD space. Hosted CI is still required.The earlier translation tree had passed full CI and a seven-state Japanese display review; those are historical results, not a full-CI or visual result for this merged source.
Refs #1581
Summary by CodeRabbit