Repository navigation
Print: choose paper size and orientation for notes and handouts - #499
Merged
Merged
Conversation
The Print page always laid notes pages and handouts out on portrait US Letter. It now offers Letter, A4, Legal and A3 in portrait or landscape, as PowerPoint's Print settings do, and the preview shows the chosen page. file.export, app.print and the MCP export tool take the same `paper` and `orientation` params; unknown values are an error. A notes page keeps its slide within the top half of the page, so landscape paper still leaves room for the notes. Full-page slides still print on slide-shaped pages. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file.export(pdf),app.printand the MCPexporttool acceptpaper: letter|a4|legal|a3andorientation: portrait|landscape; unknown values are an error instead of a silent fallback.deckcraft-pdf(PAPERS,paper_size) and the engine re-exports it for the UI, so the layer rules hold.Part of ROADMAP Upcoming item 4 (Output: printing). Doesn't touch the rasterising path that #245 (vector PDF) changes.
Test plan
cargo xtask ci(fmt, clippy, test, assets, layers, wasm)deckcraft-pdftest: every paper in both orientations gives that MediaBox for notes and handouts, and every slide box stays on the pagepdf_optionsdefaults to Letter portrait, takes A4 landscape and Legal, and rejects unknown paper or orientationprint_paramscarries paper/orientation; the preview page size follows them, except for full-page slidespaperandorientationand exports with themdeckcraft-cli run --sample --cmd 'file.export={…"layout":"notes","paper":"a4","orientation":"landscape"}'writesMediaBox[0 0 841.89 595.28]pages