Repository navigation
Title bar: Export button next to Save - #246
Merged
Merged
Conversation
The Export dialog had no visible control: the native menu bar that lists Export… is not installed, so only the command palette reached it. The quick access row now has an Export button (the existing Export icon) that opens the export dialog, enabled when a presentation is open.
- ui-parity.md: title bar row; status line and history. - ROADMAP.md: progress log line. Quick Access toolbar / title bar commands stays P (no customization); no gaps.md entry covered this.
pierrevbc
force-pushed
the
export-button
branch
from
October 13, 2026 10:13
a5c04f7 to
71ddbc5
Compare
2 tasks done
Member
|
Thank you for this contribution, @pierrevbc! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
eprintln! panics when standard error is a broken pipe (a GUI launch on Windows), and a panic inside the panic hook aborts. The "no log file" message goes through log::warn! (standard error only by then); the panic hook's fallback writes to standard error with write_fmt and ignores the error. Follow-up to storytold#239, same fix as storytold/vectorcraft#465. Co-authored-by: Brandon Thomas <echelon@gmail.com>
aiongg
added a commit
to aiongg/deckcraft
that referenced
this pull request
Oct 23, 2026
aiongg
added a commit
that referenced
this pull request
Oct 23, 2026
* Media: use craft-media for bitstream, isobmff and matroska
deckcraft-bitstream, deckcraft-isobmff and deckcraft-matroska re-export
craft_media::{bitstream, isobmff, matroska} from craft-libs. The packages
and their public paths stay, so the codec crates build unchanged.
deckcraft-bitstream keeps the decoder memory budget as its own module
(budget). deckcraft-media names the new CodecConfig::Apv entry.
* Media: pin craft-media to storytold/craft-libs at f97c84d2 (#245)
* Media: pin craft-media to storytold/craft-libs at f0ad6c1e (#246)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When this PR was opened, the Export dialog (PDF, PNG/JPEG, PPTX, outline) had no visible
control:
menus::menu_tree()lists Export…, but the native menu bar it feeds is not installed(
docs/ui-parity.md), so only the command palette reached it. The File tab (#344) has since addedFile › Export, a page of its own. Exporting a PDF to send is a frequent action, so this PR keeps a
one-click shortcut to the Export dialog in the title bar, next to Save, alongside File › Export.
(The first commit's message and the test's doc comment still describe the situation before #344.)
What changes
Two commits: the change, and the progress docs.
crates/ui-egui/src/ribbon.rs: the quick access row of the title bar gets an Export buttonafter Save, with the existing
Icon::Export(no new asset), tooltip "Export…". It runsapp.exportDialog, the command behind the menu item, so it opens the same dialog. It is enabledwhen a presentation is open, like Save.
docs/ui-parity.md(status line, history; the button isdescribed as a quick-access shortcut beside File › Export) and a
ROADMAP.mdprogress logline. "Quick Access toolbar / title bar commands" stays P in the
checklist (no customization); no
gaps.mdentry covered this.How it was tested
cargo xtask cipasses on this branch (fmt, clippy-D warnings, workspace tests, layers,assets, wasm32 check).
New test
title_bar_export_opens_the_export_dialog(crates/ui-egui/src/lib.rs, egui_kittest):a click on the third quick access button opens the
exportdialog, and no dialog is open before.Known limits
added before it would move it.
Related PRs
same need; the two are complementary and don't touch the same files.
crates/ui-egui/src/lib.rs: append-only conflict.crates/ui-egui/src/ribbon.rs, without textual conflict. Translation PRs (Add Ukrainian interface translation and language selection #34, i18n: add Russian, Spanish, French, Portuguese and German interfaces #110, i18n: add Polish (pl) interface #199) maywant the tooltip to go through their translation function.
docs/ui-parity.mdandROADMAP.md(status line, progress log) conflict with other PRs thatupdate them (Add Ukrainian interface translation and language selection #34, i18n: add Russian, Spanish, French, Portuguese and German interfaces #110, feat(theme): add System appearance across DeckCraft controls #134, Text: typing goes on after Tab in a text box (#78) #139, Export: animated GIF of the deck (Export… dialog, CLI, MCP) (#171) #177, Charts: GridCraft spreadsheet data editor and live editing for the first 5 chart types #195, Animation effects: follow the system's reduced-motion setting #196, i18n: add Polish (pl) interface #199); the resolution is to keep both lines.