Repository navigation
i18n: add Korean (ko) interface #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JaebeenAhn
wants to merge
32
commits into
storytold:main
Choose a base branch
from
JaebeenAhn:i18n-ko-v0111
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
033248d
i18n #30: add Ukrainian interface and language preference
dmatviichuk 6ee9c6a
i18n: add Polish (pl) interface
brzuchal 4571ded
Merge remote-tracking branch 'origin/main' into i18n-pl
brzuchal 13fa90a
Merge remote-tracking branch 'origin/main' into i18n-pl
brzuchal 281d318
Merge remote-tracking branch 'origin/main' into i18n-pl
brzuchal 531c4e6
Merge origin/main into i18n-pl
brzuchal 9a3ca36
Merge origin/main into i18n-pl
brzuchal 6bc4bf6
Merge origin/main into i18n-pl
brzuchal 19481bd
Merge origin/main into i18n-pl
brzuchal 6409f0f
Merge origin/main into i18n-pl
brzuchal 92f6d20
Merge origin/main into i18n-pl
brzuchal 103a1dc
Merge origin/main into i18n-pl
brzuchal 77f7b78
Merge origin/main into i18n-pl
brzuchal bc86423
Merge origin/main into i18n-pl
brzuchal 4b2be6c
Merge origin/main into i18n-pl
brzuchal 0b6fb86
Merge origin/main into i18n-pl
brzuchal 1ee4f04
Merge origin/main into i18n-pl
brzuchal 7b1c10b
Merge origin/main into i18n-pl
brzuchal 5420781
Merge origin/main into i18n-pl
brzuchal 15a8c29
Merge origin/main into i18n-pl
brzuchal 452dcd5
Merge origin/main into i18n-pl
brzuchal 33d9926
Merge origin/main into i18n-pl
brzuchal 829ca35
Merge origin/main into i18n-pl
brzuchal 4cbbe97
Merge origin/main into i18n-pl
brzuchal fd601c3
i18n: Cancel restores the interface language; app.language lists pl; …
brzuchal 862e91e
Docs: name Polish next to Ukrainian in the localization summaries
brzuchal 6963b4d
Merge origin/main into i18n-pl
brzuchal a0703ac
Merge origin/main into i18n-pl
brzuchal f4a77cd
i18n: tabs, colour controls and checker findings read in the interfac…
brzuchal 3444f33
Merge origin/main into i18n-pl
brzuchal 77dbc49
Merge origin/main into i18n-pl
brzuchal 66c4e08
i18n: add Korean (ko) interface catalog (1,486 entries) and language …
JaebeenAhn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: storytold/deckcraft
Length of output: 22344
Script executed:
Repository: storytold/deckcraft
Length of output: 1649
Update ROADMAP.md to include Korean in the shipped-language summary.
The language section lists only English, Ukrainian and Polish. Korean appears as
0%with statusnone. The Preferences sentence omits Korean, and the shipped-language line lists only Ukrainian and Polish. The shipped Korean interface contradicts these lines.The Korean language option and catalog exist in the checked-out source. Update these lines so they match:
0%/none.The header change note at line 5 should describe the Korean catalog and language selection as the latest change. Keep the dated "previous:" entries unchanged. Keep existing dated progress-log and revision-history rows (for example, lines 289 and 387) unchanged. Add a new dated row for the Korean change if the progress log requires one.
The same language summaries in
docs/localization-parity.md,docs/gaps.md,docs/roadmap.md, anddocs/target-app-parity.mdalso omit Korean. Update those summaries in the same change. Indocs/localization-parity.md, the table has 13 rows under the heading "The twelve key languages". Correct the heading to match the row count. Also update the "Other languages shipped" count and the integer-count sentence so they include Polish and Korean.