Repository navigation
Conversation
Since the egui 0.37 migration (storytold#1350), eframe's OS clipboard is the opt-in `clipboard` feature. The desktop app turns eframe's default features off and did not list it, so egui-winit fell back to a clipboard simulated inside the app: copy and paste within DeckCraft still worked, but text copied in any other program never arrived on Ctrl+V. Enable `clipboard` on the desktop app's eframe (it also turns on egui-winit's `clipboard-image`). Cargo.lock gains smithay-clipboard and its Wayland dependencies. The v0.11.1 release predates storytold#1350 and is not affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Enable clipboard feature apps/deckcraft/Cargo.toml |
The eframe dependency enables the clipboard feature. Its other enabled features remain unchanged. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Bug fix
Possibly related PRs
- storytold/deckcraft#1350: This PR migrated DeckCraft from egui 0.36 to 0.37 while retaining disabled default features. This change enables eframe’s
clipboardfeature following a reported desktop paste regression.
Suggested reviewers: alexanderalber, dylanmtaylor
Merge Risk: 
f08c9
-
The change enables the intended desktop clipboard support without an identified correctness or availability risk.
Architecture risk: 
f08c9
-
The change affects 1 system.
Changed systems:
apps/deckcraftArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — apps/deckcraft (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in apps/deckcraft/Cargo.toml: Added the
clipboardfeature to theeframedependency; the other enabled features remain unchanged.
-
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes the main change: restoring desktop paste from other applications by enabling clipboard support. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Review notes (read the diff, checked the feature wiring; I did not run a paste).
Not checked: actual paste of text from another app on Linux, Windows or macOS (needs an interactive session; WSLg's compositor is not representative anyway), and the build of the app binary here. |
|
Critical bug, merge asap pls |
|
This is critical, clipboard the most used feature in any toolkit, how is possible this is still not merge? |
|
@echelon can you pls approve this? deckcraft is almost thrash without copy and paste |
FredApps
left a comment
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the manifest hunk: the eframe clipboard feature is enabled for the desktop app so pasting from other applications works again. A feature flag on an existing dependency is a small change; the feature pulls in arboard and its platform dependencies, so check the lockfile (the new transitive dependencies' licences and the Wayland build) and that the CI builds on Linux with and without X11. I can't test paste between applications here.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
Summary
On
main, text copied in another program doesn't paste into the desktop app with Ctrl+V or Edit ▸ Paste. Copy and paste within DeckCraft still works. This is a regression from the egui 0.37 migration (#1350). The v0.11.1 release predates #1350, so released builds are not affected.Cause
In the egui fork that #1350 moved to, eframe's access to the OS clipboard is the opt-in
clipboardfeature (it enablesegui-winit/clipboardandegui-winit/clipboard-image).apps/deckcraftturns off eframe's default features and lists its own, andclipboardwasn't among them.Without that feature, egui-winit uses a clipboard simulated inside the process. A Ctrl+V therefore only ever delivers what DeckCraft itself copied.
cargo tree -e features -i egui-winitonmainshows noclipboardfeature enabled.Change
apps/deckcraft/Cargo.toml: add"clipboard"to the eframe features.Cargo.lock: addssmithay-clipboardand its Wayland dependencies, which egui-winit's clipboard pulls in.No code changes. The web app (
apps/deckcraft-web) is untouched.Related
persistence). Whichever of the two merges second gets a one-line conflict; keep both features.main.Testing
cargo build --release --locked -p deckcraft,cargo clippy --locked -p deckcraft --all-targets -D warnings,cargo fmt --checkandcargo test -p deckcraft(44 tests)all pass.cargo tree -e features -i egui-winitnow listsegui-winit feature "clipboard".🤖 Generated with Claude Code
Summary by CodeRabbit