Skip to content

fix: disable GL_EXT_win32_keyed_mutex temporary #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
storycraft merged 1 commit into from
Aug 27, 2026
Merged

fix: disable GL_EXT_win32_keyed_mutex temporary #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions crates/overlay/src/renderer/opengl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ impl GlInteropTexture {
&& gl::ImportMemoryWin32HandleEXT::is_loaded()
{
return Ok(Self::MemoryObject(
MemoryObjectTexture::open(surface, extensions)
.context("external memory texture")?,
MemoryObjectTexture::open(surface).context("external memory texture")?,
));
}

Expand Down Expand Up @@ -211,7 +210,7 @@ struct MemoryObjectTexture {
}

impl MemoryObjectTexture {
fn open(surface: &OverlaySurface, extensions: &HashSet<String>) -> anyhow::Result<Self> {
fn open(surface: &OverlaySurface) -> anyhow::Result<Self> {
unsafe {
let memory_object = scopeguard::guard(
{
Expand Down Expand Up @@ -278,9 +277,11 @@ impl MemoryObjectTexture {

Ok(Self {
memory_object: ScopeGuard::into_inner(memory_object),
keyed_mutex: surface.mutex().is_some()
&& extensions.contains("GL_EXT_win32_keyed_mutex")
&& gl::AcquireKeyedMutexWin32EXT::is_loaded(),
// Disable keyed mutex until freeze issue is resolved.
// keyed_mutex: surface.mutex().is_some()
// && extensions.contains("GL_EXT_win32_keyed_mutex")
// && gl::AcquireKeyedMutexWin32EXT::is_loaded(),
keyed_mutex: false,
id: ScopeGuard::into_inner(texture),
})
}
Expand Down
Loading